great-expectations / great_expectations

Always know what to expect from your data.
https://docs.greatexpectations.io/
Apache License 2.0
10k stars 1.55k forks source link

[MAINTENANCE] Remove commented out code #10686

Closed tyler-hoffman closed 3 days ago

tyler-hoffman commented 3 days ago

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

netlify[bot] commented 3 days ago

Deploy Preview for niobium-lead-7998 canceled.

Name Link
Latest commit 243e42be179c502ffae22fe3b657691aed2fe1c8
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/673bb26ef45a920008af4e2e
codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.47%. Comparing base (d08ed2d) to head (243e42b). Report is 3 commits behind head on develop.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #10686 +/- ## =========================================== - Coverage 80.47% 80.47% -0.01% =========================================== Files 462 462 Lines 40111 40111 =========================================== - Hits 32280 32279 -1 - Misses 7831 7832 +1 ``` | [Flag](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | Coverage Δ | | |---|---|---| | [3.10](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `68.17% <ø> (ø)` | | | [3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 bigquery](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 clickhouse](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.10 spark_connect](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `68.17% <ø> (ø)` | | | [3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 bigquery](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 clickhouse](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.11 spark_connect](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `?` | | | [3.12](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `68.16% <ø> (-0.02%)` | :arrow_down: | | [3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `55.49% <ø> (ø)` | | | [3.12 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `46.14% <ø> (ø)` | | | [3.12 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.74% <ø> (ø)` | | | [3.12 bigquery](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `45.91% <ø> (ø)` | | | [3.12 databricks](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `48.08% <ø> (ø)` | | | [3.12 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `61.71% <ø> (ø)` | | | [3.12 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `51.49% <ø> (ø)` | | | [3.12 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `51.55% <ø> (ø)` | | | [3.12 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.62% <ø> (ø)` | | | [3.12 snowflake](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `48.85% <ø> (ø)` | | | [3.12 spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `58.07% <ø> (ø)` | | | [3.12 spark_connect](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `46.44% <ø> (ø)` | | | [3.12 trino](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.67% <ø> (ø)` | | | [3.9](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `68.19% <ø> (-0.02%)` | :arrow_down: | | [3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `55.49% <ø> (ø)` | | | [3.9 aws_deps](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `46.16% <ø> (ø)` | | | [3.9 big](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.76% <ø> (ø)` | | | [3.9 bigquery](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `45.92% <ø> (ø)` | | | [3.9 clickhouse](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `43.03% <ø> (ø)` | | | [3.9 databricks](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `48.10% <ø> (ø)` | | | [3.9 filesystem](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `61.73% <ø> (ø)` | | | [3.9 mssql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `51.47% <ø> (ø)` | | | [3.9 mysql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `51.54% <ø> (ø)` | | | [3.9 postgresql](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `54.60% <ø> (ø)` | | | [3.9 snowflake](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `48.87% <ø> (ø)` | | | [3.9 spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `58.04% <ø> (ø)` | | | [3.9 spark_connect](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `46.45% <ø> (ø)` | | | [3.9 trino](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.66% <ø> (ø)` | | | [cloud](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `0.00% <ø> (ø)` | | | [docs-basic](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `53.40% <ø> (ø)` | | | [docs-creds-needed](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.97% <ø> (ø)` | | | [docs-spark](https://app.codecov.io/gh/great-expectations/great_expectations/pull/10686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations) | `52.46% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=great-expectations#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: