great-expectations / great_expectations

Always know what to expect from your data.
https://docs.greatexpectations.io/
Apache License 2.0
9.88k stars 1.53k forks source link

Please don't turn on DeprecationWarnings #4119

Closed jobevers closed 1 month ago

jobevers commented 2 years ago

https://github.com/great-expectations/great_expectations/blob/develop/great_expectations/expectations/metrics/meta_metric_provider.py#L27

Turning on DeprecationWarnings like this overrides any settings we already have.

Our current workaround is:

import warnings
filters = list(warnings.filters)

from great_expectations.data_context.types.base import DataContextConfig
from great_expectations.data_context import BaseDataContext
from great_expectations.core.batch import RuntimeBatchRequest

warnings.filters = filters
kenwade4 commented 2 years ago

Hi @jobevers and @dtomlinson91, this is unfortunate that this is overriding your project level settings. We will look into more consistent usage of logger methods and replacing use of the warnings module. We will be in touch.

molliemarie commented 1 month ago

Hi @jobevers. With the upcoming launch of Great Expectations Core (GX 1.0), we are closing old issues posted regarding previous versions. Moving forward, we will focus our resources on supporting and improving GX Core (version 1.0 and beyond). If you find that an issue you previously reported still exists in GX Core, we encourage you to resubmit it against the new version. With more resources dedicated to community support, we aim to tackle new issues swiftly. For specific details on what is GX-supported vs community-supported, you can reference our integration and support policy.

To get started on your transition to GX Core, check out the GX Core quickstart (click “Full example code” tab to see a code example).

You can also join our upcoming community meeting on August 28th at 9am PT (noon ET / 4pm UTC) for more updates on GX Core. Go to https://greatexpectations.io/meetup and click “follow calendar” to follow the GX community calendar.

Thank you for being part of the GX community and thank you for submitting this issue. We're excited about this new chapter and look forward to your feedback on GX Core. 🤗

molliemarie commented 1 month ago

Closing