search

great-expectations / great_expectations_action

A GitHub Action that makes it easy to use Great Expectations to validate your data pipelines in your CI workflows.
MIT License
78 stars 12 forks source link

test GE Actions and remove "test badges" #75

Closed hamelsmu closed 4 years ago

hamelsmu commented 4 years ago

I'm testing the Action Removing badges for tests that fail on purpose because we are testing the test

cc: @Aylr

github-actions[bot] commented 4 years ago

test of input: npi.pass

All Checkpoints for: 463e2e4d34dfcd5a32af5f1ab45c47c15bdceed8 have passed. Corresponding Data Docs have been generated and can be viewed here.

github-actions[bot] commented 4 years ago

test of input: npi.fail

Failed Great Expectations checkpoint(s) npi.fail detected for: 463e2e4d34dfcd5a32af5f1ab45c47c15bdceed8. Corresponding Data Docs have been generated and can be viewed here.

github-actions[bot] commented 4 years ago

test of input: npi.pass,npi.fail

Failed Great Expectations checkpoint(s) npi.fail detected for: 463e2e4d34dfcd5a32af5f1ab45c47c15bdceed8. Corresponding Data Docs have been generated and can be viewed here.

github-actions[bot] commented 4 years ago

test of input: npi.fail,npi.pass

Failed Great Expectations checkpoint(s) npi.fail detected for: 463e2e4d34dfcd5a32af5f1ab45c47c15bdceed8. Corresponding Data Docs have been generated and can be viewed here.

hamelsmu commented 4 years ago

Ok lets see if commenting works as well.

/data-docs

github-actions[bot] commented 4 years ago

test of input (PR Comment): npi.fail

Failed Great Expectations checkpoint(s) npi.fail detected for: a77ea1c5ed26d82f4dea8d87f14ddd8c05824818. Corresponding Data Docs have been generated and can be viewed here.

github-actions[bot] commented 4 years ago

test of input (PR Comment): npi.pass,npi.fail

Failed Great Expectations checkpoint(s) npi.fail detected for: a77ea1c5ed26d82f4dea8d87f14ddd8c05824818. Corresponding Data Docs have been generated and can be viewed here.

github-actions[bot] commented 4 years ago

test of input (PR Comment): npi.fail,npi.pass

Failed Great Expectations checkpoint(s) npi.fail detected for: a77ea1c5ed26d82f4dea8d87f14ddd8c05824818. Corresponding Data Docs have been generated and can be viewed here.

github-actions[bot] commented 4 years ago

test of input (PR Comment): npi.pass

All Checkpoints for: a77ea1c5ed26d82f4dea8d87f14ddd8c05824818 have passed. Corresponding Data Docs have been generated and can be viewed here.

hamelsmu commented 4 years ago

@Aylr see above. Tested for both comments and for PR activity.

For all practical purposes, I only think Actions should comment on pushes when there is a failure, otherwise would be way too much noise for most people to just automatically comment on each success.

However, for the chat command, I think it should comment either way on success OR failure. WDYT? I have updated the README accordingly.

I believe we are all good.

This and prior PRs close #71