search

great-expectations / great_expectations_action

A GitHub Action that makes it easy to use Great Expectations to validate your data pipelines in your CI workflows.
MIT License
80 stars 11 forks source link

Updated nodejs version to LTS to avoid compatibility issues with npm #80

Closed sravantit25 closed 1 year ago

sravantit25 commented 2 years ago

Fix for the below issue: https://github.com/great-expectations/great_expectations_action/issues/79

Summary: great_expectations_action build docker image is failing with incompatible Node.js version

sravantit25 commented 2 years ago

@cla-bot check

sravantit25 commented 2 years ago

Howdy, the team raises a very strong point, which is can we just pin a version of node rather than have a remote script.

The script points to the Long Term Supported version (LTS) which will automatically get upgraded to the next supported version when this version gets outdated. The link always remains updated. But if this is really a concern, I will update it to a specific version. Do let me know.

sravantit25 commented 2 years ago

Hello! Can you let me know your thoughts on the above PR? I can make the change if required, submit for review and close it! Thank you!

jcampbell commented 1 year ago

I'm going to merge this as-is, but also mark this action as explicitly no longer maintained. With changes to the underlying GX that have happened in the past couple of years, we recommend using checkpoints directly now!