search

great-lakes / project-egypt

MIT License
0 stars 0 forks source link

addin explicit stage for pull request #68

Closed saroup closed 6 years ago

in4margaret commented 6 years ago

@saroup yarn is running by default if we don't have install block

in4margaret commented 6 years ago

@saroup we use standard.js (https://standardjs.com/) for linting and added it to package.json test to run it to make sure we follow standards.

in4margaret commented 6 years ago

This closes #61 #62 #42

in4margaret commented 6 years ago

@saroup We need "yarn build" twice because one is used to test that it can be built in 'test' stage and another one is used in deploy. Otherwise we would need to add data persistence between jobs as described in https://docs.travis-ci.com/user/build-stages/#Data-persistence-between-stages-and-jobs

saroup commented 6 years ago

Also closes #54

in4margaret commented 6 years ago

@saroup We use cache for yarn to speed up installing of packages as they don't change often

in4margaret commented 6 years ago

fixes #54 #62 #61 #42