CC64 midi controller not working

[Exink]

Hi, I'd like to suggest that this plug-in could handle the MIDI CC64 hold controller (or any other foot /sustain controller)), so that we could use it for piano like patches or anything similar. I haven't being able to make it work, that's why I'm opening this issue.

If there's some way to use this feature, please let me know. Otherwise hopefully this could be implemented in future releases.

Thanks a lot for making this great synth!

Best regards.

[greatest-ape]

No such support is implemented at the moment, but it sounds like a reasonable thing to add.

Is the concept that while the pedal is pressed down, notes stay on (stay in sustain phase) even if the corresponding keys are no longer pressed?

[Exink]

Yes, that's supposed to happen, so this concept is more similar to the sustain-pedal of a piano. I don't know if other controllers work differently, but indeed once the controller 64 is activated, as lon as it's on, notes should keep playing even if you release them. However once is disabled and there are no more notes playing, there shouldn't be any audible sound. It takes two values to work, from 0 to 63 disables it and 64 to 127 to enable.

[greatest-ape]

Could you please try out this build with support added, check if it works and see if there are any issues?

OctaSine-tmp-2022-11-08-Windows.zip OctaSine-tmp-2022-11-08-macOS.zip OctaSine-tmp-2022-11-08-Ubuntu-20_04.zip

[Exink]

That's perfect! I've just tested it on my personal DX7-EP1 patch recreation and it works as intended. Personally I haven't found any issue so far, even after playing various notes at once. Do you need an audio sample?

[greatest-ape]

Thanks, great! No, it’s ok :-)

I’ve merged the fix and it will be included in next release.

[Exink]

Ok, thanks a lot! Looking forward to the next one :).