greatest-ape / OctaSine

Frequency modulation synthesizer plugin (VST2, CLAP). Runs on macOS, Windows and Linux.
https://www.octasine.com/
GNU Affero General Public License v3.0
634 stars 17 forks source link

No GUI for clap plugin in Bitwig #145

Open greatest-ape opened 1 year ago

greatest-ape commented 1 year ago

A report has come in of no GUI appearing in Bitwig when using the CLAP plugin.

tank-trax commented 1 year ago

I can confirm this, clap shows in Reaper, not in Bitwig

TjShredder commented 1 year ago

I can confirm this as well. VST shows the GUI...

greatest-ape commented 1 year ago

The latest release should now work on Windows, but unfortunately not yet on macOS.

tank-trax commented 1 year ago

still no GUI in Bitwig for the CLAP on my end v8.4 on Linux Mint 21.1

greatest-ape commented 1 year ago

Alright, annoying. For some reason Bitwig doesn’t seem to play nice with baseview / iced_baseview.

TjShredder commented 1 year ago

You should report it also to Bitwig, they want CLAP to be a selling point and might help you to sort it out... Its all new and exciting...

tank-trax commented 1 year ago

good idea and I agree

porzione commented 1 year ago

Maybe related https://github.com/free-audio/clap/issues/323

greatest-ape commented 1 year ago

Yeah, that looks related.

greatest-ape commented 5 months ago

If any of you have the time, could you please try this build out and see if it works?

OctaSine-tmp-2024-03-16-macOS.zip OctaSine-tmp-2024-03-16-Windows.zip

josb commented 5 months ago

FYI https://nakst.gitlab.io/tutorial/clap-part-3.html shows .set_parent not just storing the host window pointer, but also setting it as the plugin window parent by calling [parentView addSubview:mainView].

Edit: I now realize the open_parented() call in show() is what effectively ends up doing the same thing as the above example, except here it happens in the show() call because open_parented() both creates and shows the plugin window. Hope my understanding is correct.

josb commented 5 months ago

Your tmp build gives the CouldNotReadMetaDataException during scan (but clearly some versions did pass the scan before). This is with Sonoma 14.4. Maybe it's an OS issue? Installed using

cd ~/Downloads
unzip OctaSine-tmp-2024-03-16-macOS.zip
sudo cp -r OctaSine/CLAP/OctaSine\ v0.9.clap /Library/Audio/Plug-Ins/CLAP
sudo xattr -d -r com.apple.quarantine /Library/Audio/Plug-Ins/CLAP/OctaSine\ v0.9.clap

But! Your work-2024-03-09 branch built here does show the GUI. 👍

greatest-ape commented 5 months ago

Yes, you’re right about open_parented, so it’s just a way to try to make it work with the baseview API.

Nice! Does CPU use drop again when the plugin window is closed/hidden? It was an issue previously that it did not, because the window wasn’t properly cleaned up.

tank-trax commented 5 months ago

I can build the latest VST2 but not the Clap as my rust is not recent enough using Debian 12

josb commented 5 months ago

Thanks @greatest-ape, for confirming my understanding around open_parented().

I'll look into the CPU behavior soon and will report back. Looking at recent commits, latest iced_baseview is supposed to have addressed this.

greatest-ape commented 5 months ago

I can build the latest VST2 but not the Clap as my rust is not recent enough using Debian 12

Ok! Are you using Debian-packaged Rust? My current rust version policy is latest stable and I will probably not change it. I was happy to be able to get off nightly Rust a while back.

greatest-ape commented 5 months ago

Thanks @greatest-ape, for confirming my understanding around open_parented().

I'll look into the CPU behavior soon and will report back. Looking at recent commits, latest iced_baseview is supposed to have addressed this.

Ok, thanks!

I’ve switched to a fork of iced_baseview since I don’t want to upgrade to a more recent iced version yet, since it causes various crashes, bugs and performance issues that I don’t want to spend time on ironing out.

RustoMCSpit commented 4 months ago

can confirm too lol

RustoMCSpit commented 2 months ago

this is still broken on linux mint

greatest-ape commented 2 months ago

this is still broken on linux mint

Ok, even on v0.9.1?

RustoMCSpit commented 2 months ago

this is still broken on linux mint

Ok, even on v0.9.1?

yes

greatest-ape commented 2 months ago

Ok :(