greatest-ape / OctaSine

Frequency modulation synthesizer plugin (VST2, CLAP). Runs on macOS, Windows and Linux.
https://www.octasine.com/
GNU Affero General Public License v3.0
650 stars 18 forks source link

Exposed symbols on local build #150

Closed tank-trax closed 1 year ago

tank-trax commented 1 year ago

Successfully built clap and vst3 on Debian 11

after building noticed that both plugins exposed an extra symbol

for example the prebuilt binaries I downloaded

objdump -T OctaSine\ v0.8.clap | grep ' g '
0000000000368408 g    DO .data.rel.ro   0000000000000028  Base        clap_entry
objdump -T OctaSine\ v0.8.so | grep ' g '
00000000000bd6c0 g    DF .text  0000000000000005  Base        VSTPluginMain
objdump -T octasine.clap | grep ' g '
00000000000af400 g    DF .text  0000000000000005  Base        VSTPluginMain
000000000038aca8 g    DO .data.rel.ro   0000000000000028  Base        clap_entry
objdump -T octasine.so | grep ' g '
00000000000af400 g    DF .text  0000000000000005  Base        VSTPluginMain
000000000038aca8 g    DO .data.rel.ro   0000000000000028  Base        clap_entry

still no GUI in Bitwig

however.... as the bleeding edge does not have the orange box to open GUI

image

the master branch does, however it does not open, it tries then disappears

image

greatest-ape commented 1 year ago

Thanks.

Is the GUI working in Bitwig with any of vst or clap formats on master branch?

tank-trax commented 1 year ago

for the binary you provided the VST GUI loads in Bitwig and Reaper, the CLAP GUI only loads in Reaper

the prebuilt binary also has no option to display in Carla whereas the one I built does and loads

the clap I built locally as well as the one available online also displays in QTractor

looks like an issue with Bitwig, that being said other claps load in BWS

image

greatest-ape commented 1 year ago

Thanks! When you open the VST GUI in Bitwig, are there any other issues? I've got it to load on macOS but resources are not freed properly when the plugin window is closed, so every time that the window is opened again, CPU consumption increases. Hopefully, this issue is not present on Linux.

Regarding the symbols, the fix is to pass --no-default-features --features "glow vst2" or --no-default-features --features "glow clap" to the cargo xtask build command, which is indeed done for the prebuilt binaries. I'll update the README.

greatest-ape commented 1 year ago

I’ve updated the README.