greatexpectationslabs / cooper-pair

Cooper Pair is a Python library to simplify programmatic access to the Allotrope GraphQL API.
Apache License 2.0
0 stars 0 forks source link

Need a way to update checkpoints with an expectations config #2

Open thethingstheycoded opened 6 years ago

thethingstheycoded commented 6 years ago

update_checkpoint takes a different form for expectations than add_checkpoint_from_expectations_config. There should be a way to update checkpoints by passing a full expectations_config

    def update_checkpoint(
            self,
            checkpoint_id,
            autoinspection_status=None,
            expectations=None,
            sections=None):
        """Update an existing checkpoint.
        Args:
            checkpoint_id (int or str Relay id) -- The id of the checkpoint
                to update.
        Kwargs:
            autoinspection_status (str) -- The status of autoinspection, if
                that is to be updated (default: None, no change).
            expectations (list) -- A list of dicts representing expectations
                to be created & added to the checkpoint (default: None,
                no change). Note: semantics are append.
            sections (list) -- A list of dicts representing sections, with
                optionally nested questions and expectations, each to be
                created and associated (default: None, no change). Note:
                semantics are append.

...
    def add_checkpoint_from_expectations_config(
            self, expectations_config, name):
        """Create a new checkpoint from a great_expectations expectations
            config.
        Args:
            expectations_config (dict) - An expectations config as returned by
                great_expectations.dataset.DataSet.get_expectations_config.
                Note that this is not validated here or on the server side --
                failures will occur at evaluation time.