cli: add flash-fast command

greatscottgadgets / apollo

microcontroller-based FPGA / JTAG programmer

BSD 3-Clause "New" or "Revised" License

61 stars 29 forks source link

cli: add flash-fast command #25

Closed mndza closed 5 months ago

mndza commented 12 months ago

This PR adds a command to Apollo CLI (apollo flash-fast) for flash programming. This command first programs a gateware SPI bridge to the FPGA and then uses it to access the configuration SPI flash.

mndza commented 11 months ago

True, let's wait until that other PR is ready (I'm marking as draft to avoid confusion).

I would like to create a PR with the ApolloAdvertiser injection code first (should that go in the cynthion repo?). That's why https://github.com/greatscottgadgets/luna/pull/220 is still a draft (it creates a manual instance of the advertiser).

I do not have a strong opinion on the location of the flash bridge gateware. If we decide the code belongs here, I'm willing to move it.

martinling commented 11 months ago

There's three parts as I see it:

support for platform-specific hooks, which needs to be added to USBDevice in the LUNA repo.
the hooks, which need to be added to the platform definitions in the Cynthion repo.
the ApolloAdvertiser gateware, which I think should live in apollo_fpga.gateware and can be imported from there by all Apollo-based platforms that need it (which will include Cynthion, URTI and others).

mndza commented 5 months ago

Rebased.

Changed bInterfaceSubclass to 0x01 to avoid conflict with Apollo stub interface.
Added a final trigger reconfiguration step when closing the connection with the flash bridge. This makes flash-fast inconsistent with the flash command (which does not trigger a reconfiguration), but avoids keeping the Flash bridge enumerated.