While trying to create system packages on Linux for Cynthion and for the gateware binaries and bitstreams, I noticed that the cynthion wheels on PyPI currently ship a directory that installs to site-packages/assets (i.e., an immediate subdirectory of site-packages).
I believe this may be a mistake, and that the actual intention was to ship a directory that installs tosite-packages/cynthion/assets, not site-packages/assets.
Expected behavior
assets is a subdirectory of the cynthion package directory, so it can’t clash with another Python package named assets in the same environment.
The function call cynthion.cynthion_assets_directory() returns a directory that exists and contains the assets.
The function call cynthion.find_cynthion_asset('apollo.bin') returns the path name to the apollo.bin asset.
Actual behavior
assets is an immediate subdirectory of site-packages. This might cause a conflict if another Python package named assets is installed in the same environment.
The function call cynthion.cynthion_assets_directory() returns a directory that doesn’t exist.
The function call cynthion.find_cynthion_asset('apollo.bin') returns None.
Steps to reproduce
Create and activate a fresh Python virtual environment.
For example on a Linux shell:
cd "$(mktemp -d)"
python -m venv .venv
. .venv/bin/activate
Install Cynthion v0.1.1 from PyPI:
pip install cynthion==0.1.1
Confirm that the assets directory is a direct subdirectory of site-packages:
I haven’t been able to check whether the cynthion CLI command works as intended, because my Cynthion is yet to arrive.
Several people on Discord have reported their setup is working. So what am I missing?
Summary
While trying to create system packages on Linux for Cynthion and for the gateware binaries and bitstreams, I noticed that the
cynthion
wheels on PyPI currently ship a directory that installs tosite-packages/assets
(i.e., an immediate subdirectory ofsite-packages
).I believe this may be a mistake, and that the actual intention was to ship a directory that installs to
site-packages/cynthion/assets
, notsite-packages/assets
.Expected behavior
assets
is a subdirectory of thecynthion
package directory, so it can’t clash with another Python package namedassets
in the same environment.cynthion.cynthion_assets_directory()
returns a directory that exists and contains the assets.cynthion.find_cynthion_asset('apollo.bin')
returns the path name to theapollo.bin
asset.Actual behavior
assets
is an immediate subdirectory ofsite-packages
. This might cause a conflict if another Python package namedassets
is installed in the same environment.cynthion.cynthion_assets_directory()
returns a directory that doesn’t exist.cynthion.find_cynthion_asset('apollo.bin')
returnsNone
.Steps to reproduce
Create and activate a fresh Python virtual environment. For example on a Linux shell:
Install Cynthion v0.1.1 from PyPI:
Confirm that the
assets
directory is a direct subdirectory ofsite-packages
:Confirm that the
cynthion_assets_directory()
function returns a non-existent directory:Confirm that calls to the
find_cynthion_asset
function return nothing:Note
I haven’t been able to check whether the
cynthion
CLI command works as intended, because my Cynthion is yet to arrive.Several people on Discord have reported their setup is working. So what am I missing?