greatscottgadgets / luna

Amaranth HDL framework for monitoring, hacking, and developing USB devices
https://greatscottgadgets.com/cynthion/
BSD 3-Clause "New" or "Revised" License
991 stars 171 forks source link

gateware: fix pin assignments and remove deprecated `Case()` #239

Closed mndza closed 8 months ago

antoinevg commented 8 months ago

This is failing the CI tests: https://github.com/greatscottgadgets/luna/actions/runs/8236675456/job/22523664217#step:5:32

This is building for me on amaranth==0.4.1 which should be equivalent to luna's amaranth~=0.4.0 but I'm probably the last person to ask about pip package resolution.

We're in a weird place, we need a stable pin for cynthion release but there's a lot of things in luna we need for urti and it would be nice to not have to rewrite them when amaranth>=0.5 comes out. 😛

miek commented 8 months ago

This is building for me on amaranth==0.4.1 which should be equivalent to luna's amaranth~=0.4.0 but I'm probably the last person to ask about pip package resolution.

Is that just building a design, or running the tests? That test fails locally for me with amaranth 0.4.1.

antoinevg commented 8 months ago

Argh okay, I only ran builds here.

mndza commented 8 months ago

Updated the tests.

miek commented 8 months ago

Thanks!