search

greatscottgadgets / luna

Amaranth HDL framework for monitoring, hacking, and developing USB devices
https://greatscottgadgets.com/cynthion/
BSD 3-Clause "New" or "Revised" License
989 stars 171 forks source link

SPIBus should be reworked to be compliant with the new SPIResource naming #37

Open ktemkin opened 4 years ago

ktemkin commented 4 years ago

Last year, creating the hardware designs, we used sdi and sdo to avoid problematic names. This year, we've standardized on copi and cipo for SPI naming. nmigen-boards now uses the new standard.

We should replace the names:

[ ] In the SPI interface, and its SPIBus. [ ] In the examples. [ ] In the ILA. [ ] In the firmware.

mossmann commented 3 years ago

The OSHWA resolution prefers SDI/SDO except for cases where controller/peripheral roles (and signal direction) can be swapped. As SPIBus only implements a peripheral, I think it would be fine to retain SDI/SDO. There are a few uses of MOSI/MISO/master/slave that could be changed, however.