search

greatspn / SOURCES

Main repository of the GreatSPN framework
GNU General Public License v2.0
42 stars 13 forks source link

8 docker build #12

Closed millergarym closed 4 years ago

millergarym commented 4 years ago

There are still some issues with this docker build of GreatSPN. Recreating this PR to help track them.

amparore commented 4 years ago

I moved the added files to the docker/fedora directory

millergarym commented 4 years ago

@amparore Thanks for merging the PR. With the move the docker_build.sh needs to be modified.

current

docker build -t gspn . -f fedora.dockerfile

The build context needs to be a the top level. Maybe something like

docker build -t gspn ../.. -f fedora.dockerfile
                                         ^
                                         might need path here
amparore commented 4 years ago

ah, I see, you use the SOURCES directory in the COPY rule of the dockerfile. Is this the behaviour you want? Isn't it better to get the sources from the repository?

Il giorno gio 28 mag 2020 alle ore 04:32 Gary Miller < notifications@github.com> ha scritto:

@amparore https://github.com/amparore Thanks for merging the PR. With the move the docker_build.sh needs to be modified.

current

docker build -t gspn . -f fedora.dockerfile

The build context needs to be a the top level. Maybe something like

docker build -t gspn ../.. -f fedora.dockerfile ^ might need path here

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/greatspn/SOURCES/pull/12#issuecomment-635057710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLFJES2ICOOY53OC2SGXEDRTXEKHANCNFSM4NL42SQA .

millergarym commented 4 years ago

Isn't it better to get the sources from the repository?

Getting the source from the repository during the docker build couples git and docker together. I feel this is bad practise, it makes the build overly complex (eg download.sh) and make local development more difficult. I am recently new to Petri Nets and from what I can see GreatSPN is one of the best and easiest editors out there, but I haven't managed to get it fully functional. Would it be possible to for you to build and run it fully in the docker environment and help iron out some of the issues?