search

greatspn / SOURCES

Main repository of the GreatSPN framework
GNU General Public License v2.0
42 stars 13 forks source link

reserved identifier violation #41

Open elfring opened 1 year ago

elfring commented 1 year ago

I would like to point out that identifiers like “__NUMERIC_H__” and “UNION_FIND__H” do eventually not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

amparore commented 1 year ago

It depends. Are these non-conforming macro names creating some direct issue? Because the codebase contains several non-modern C/C++ language convention examples, but many code sections are in maintenance mode, where only bugs are fixed, but no major code refactoring is performed.

elfring commented 1 year ago

How do you think about to avoid that this software depends on undefined behaviour? 🤔