Vestigial No Nag Code

[ctsstc]

It seems that No Nag was removed in: #1135 In this commit: 1608710 (#1135)

There are still some leftovers that don't seem to be in use, unless it's still trying to keep track of whether or not someone donated in the past? If that is the case then it should be renamed away from "nag" to "donation".

• https://github.com/greatsuspender/thegreatsuspender/blob/108c2370b030ea47296adc86bec8456cc5151e0e/src/js/gsAnalytics.js#L52
  • This could break analytic tracking if we still care at this point, so the dimension value should just be hard coded now?
• https://github.com/greatsuspender/thegreatsuspender/blob/master/src/js/gsStorage.js
  • https://github.com/greatsuspender/thegreatsuspender/blob/108c2370b030ea47296adc86bec8456cc5151e0e/src/js/gsStorage.js#L22
  • https://github.com/greatsuspender/thegreatsuspender/blob/108c2370b030ea47296adc86bec8456cc5151e0e/src/js/gsStorage.js#L66
  • https://github.com/greatsuspender/thegreatsuspender/blob/108c2370b030ea47296adc86bec8456cc5151e0e/src/js/gsStorage.js#L122-L130
  • https://github.com/greatsuspender/thegreatsuspender/blob/108c2370b030ea47296adc86bec8456cc5151e0e/src/js/gsStorage.js#L228

[ossilator]

these are good observations, but TGS is currently unmaintained here, and the store version is likely even malicious (see #1263).