greatsuspender / thegreatsuspender

A chrome extension for suspending all tabs to free up memory
https://chrome.google.com/webstore/detail/the-great-suspender/klbibkeccnjlkjkiokjodocebajanakg/
GNU General Public License v2.0
5.04k stars 906 forks source link

Page that auto refreshes will not auto suspend #812

Open rwheels opened 6 years ago

rwheels commented 6 years ago

I suspect that because the site auto refreshes, TGS considers this activity and does not suspend it?

Site is www.reaclearpolitics.com.

Site DOES suspend if done manually.

deanoemcke commented 6 years ago

I assume the url you were meant to post was https://www.realclearpolitics.com ? I can't replicate this sorry. It seems to suspend fine with a 20 second timeout both on v6.30 and the latest development version. Are you sure the site hasn't been whitelisted or is paused due to form input or something?

rwheels commented 6 years ago

Thanks for looking at it! Yes - that's the correct url.

It's definitely not whitelisted (only 1 url is), and there are no form input fields that I can see. I've unticked 'Do not suspend tabs that contain unsaved form inputs' as well as the option for tabs playing audio just to be sure. Even with the timeout set to 20 seconds, that one tab won't suspend.

Any suggestions?

Thanks!

deanoemcke commented 5 years ago

@rwheels I've managed to reproduce your issue, although not with a 20 second suspend timer. The issue is as you guessed, because the tab is performing a reload by itself, this resets the suspend timer. For me it looks like the reload happens every 5 minutes, which means any suspend timer of 5 minutes or more will fail to suspend the tab. I'll keep this issue open, although I won't be able to do anything about it right now, as the extension using this trigger (tab loading complete) as part of it's calculation to determine how long a tab has been open for.

fwextensions commented 5 years ago

Maybe track the url across loads, and if it’s the same, don’t reset the timer?