search

greduan / emacs-theme-gruvbox

Gruvbox is a retro groove color scheme for Emacs. Port of the Vim version.
https://github.com/morhetz/gruvbox
MIT License
592 stars 87 forks source link

python-mode changing the color of matched parentheses and brighter line numbers #108

Closed haluk closed 6 years ago

haluk commented 6 years ago

I'm submitting a:

Feature request (ignore if this is a bug report.)

I love the gruvbox-theme but the color of matched parentheses is not obvious as opposed to mismatched color. A blue variant color to matched parentheses can be better fit to a theme. Also, brighter line numbers would be great too.

Please provide a relevant screenshot to illustrate the problem.

screenshot from 2018-02-07 16-17-14 screenshot from 2018-02-07 16-17-29

Please tell us about your environment.

Emacs snapshot configured by prelude.

martijnat commented 6 years ago

I don't have time right now but I will look into it tomorrow.

Part of the problem is that the face contrasts badly with the line highlighting you have. It actually contrast decently with hl-line disabled. I will have to try a few things to see what combinations work well.

Brighter line numbers is easy.

martijnat commented 6 years ago

This is what I came up with:

hl-line-match hl-line-mismatch

Let me know if this works for you.

haluk commented 6 years ago

This looks good to me. Thanks.