search

greearb / ath10k-ct

Stand-alone ath10k driver based on Candela Technologies Linux kernel.
111 stars 40 forks source link

ath10k-ct: fix compilation without debugfs #133

Closed cotequeiroz closed 4 years ago

cotequeiroz commented 4 years ago

The debug record in struct ath10k can only be used when compiled with debugfs. This fixes some unconditional uses in coredump.c and wmi.c.

Signed-off-by: Eneas U de Queiroz cotequeiroz@gmail.com

This was only compile-tested with openwrt, but the changes are somewhat trivial.

cotequeiroz commented 4 years ago

When compiled without debugfs, this generates this warning:

ath10k-5.4/coredump.c:1124:43: warning: unused variable 'dbglog_storage' [-Wunused-variable]
  struct ath10k_dbglog_entry_storage_user *dbglog_storage;
                                           ^~~~~~~~~~~~~~

I don't know if I should leave it there or not. At first I had it conditionally removed, then changed my mind, as it is is just a harmless warning (there's the warning about disabling DEBUGFS already anyway), and it may be used in the future for other stuff.

greearb commented 4 years ago

I'd rather not add compile warnings, so please fix that unused variable warning.

cotequeiroz commented 4 years ago

Done.