greearb
commented
5 years ago This looks like the prefetch scheduler bug I fixed recently. Please see if the attached FW works better. firmware-5-full-community.bin.gz
Closed ynezz closed 5 years ago
greearb
commented
5 years ago This looks like the prefetch scheduler bug I fixed recently. Please see if the attached FW works better. firmware-5-full-community.bin.gz
ynezz
commented
5 years ago Thanks, so far it's looking good, just this probably harmless warning:
ath10k_ahb a800000.wifi: Invalid peer id 2 or peer stats buffer, peer: (null) sta: (null)I'll keep you updated.
ynezz
commented
5 years ago @greearb Ben, not sure if it's related to that new firmware 10.4b-ct-4019-fW-012-c2d65911, but I've just discovered following in my logs:
16:57:13 hostapd: wlan1: interface state DISABLED->COUNTRY_UPDATE
16:57:13 hostapd: wlan1: interface state COUNTRY_UPDATE->HT_SCAN
16:57:14 hostapd: wlan1: interface state HT_SCAN->DFS
16:57:14 hostapd: wlan1: DFS-CAC-START freq=5500 chan=100 sec_chan=1, width=1, seg0=106, seg1=0, cac_time=60s
16:57:18 hostapd: wlan1: DFS-CAC-COMPLETED success=0 freq=5500 ht_enabled=0 chan_offset=0 chan_width=3 cf1=5530 cf2=0
16:57:18 hostapd: wlan1: DFS-RADAR-DETECTED freq=5500 ht_enabled=0 chan_offset=0 chan_width=3 cf1=5530 cf2=0
16:57:18 hostapd: wlan1: DFS-NEW-CHANNEL freq=5180 chan=36 sec_chan=1
16:57:18 hostapd: Using interface wlan1 with hwaddr b8:ec:a3:xx:xx:xx and ssid "fresh-rum-daily"
16:57:19 kernel: [212134.380357] ------------[ cut here ]------------
16:57:19 kernel: [212134.380532] WARNING: CPU: 0 PID: 0 at /var/lib/buildbot/slaves/slashdirt-03/MAIN/build/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/linux-ipq40xx/ath10k-ct-2018-12-20-118e16da/ath10k-4
16:57:19 kernel: [212134.384909] Modules linked in: pppoe ppp_async ath10k_pci ath10k_core ath pppox ppp_generic nf_conntrack_ipv6 mac80211 iptable_nat ipt_REJECT ipt_MASQUERADE cfg80211 xt_time xt_tcpudp xt_stat
16:57:19 kernel: [212134.453336] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.14.94 #0
16:57:19 kernel: [212134.475462] Hardware name: Generic DT based system
16:57:19 kernel: [212134.481482] [<c030e774>] (unwind_backtrace) from [<c030ac9c>] (show_stack+0x10/0x14)
16:57:19 kernel: [212134.486159] [<c030ac9c>] (show_stack) from [<c072c248>] (dump_stack+0x88/0x9c)
16:57:19 kernel: [212134.494142] [<c072c248>] (dump_stack) from [<c03173e4>] (__warn+0xe4/0x100)
16:57:19 kernel: [212134.501260] [<c03173e4>] (__warn) from [<c03174b0>] (warn_slowpath_null+0x20/0x28)
16:57:19 kernel: [212134.508623] [<c03174b0>] (warn_slowpath_null) from [<bf2e71e8>] (ath10k_htt_t2h_msg_handler+0xf00/0x2530 [ath10k_core])
16:57:19 kernel: [212134.516064] [<bf2e71e8>] (ath10k_htt_t2h_msg_handler [ath10k_core]) from [<bf2e73b8>] (ath10k_htt_t2h_msg_handler+0x10d0/0x2530 [ath10k_core])
16:57:19 kernel: [212134.527137] [<bf2e73b8>] (ath10k_htt_t2h_msg_handler [ath10k_core]) from [<bf2e86b4>] (ath10k_htt_t2h_msg_handler+0x23cc/0x2530 [ath10k_core])
16:57:19 kernel: [212134.539723] [<bf2e86b4>] (ath10k_htt_t2h_msg_handler [ath10k_core]) from [<bf2e8ef0>] (ath10k_htt_txrx_compl_task+0x6cc/0xb78 [ath10k_core])
16:57:19 kernel: [212134.552541] [<bf2e8ef0>] (ath10k_htt_txrx_compl_task [ath10k_core]) from [<bf3382d4>] (ath10k_pci_napi_poll+0x70/0x100 [ath10k_pci])
16:57:19 kernel: [212134.565348] [<bf3382d4>] (ath10k_pci_napi_poll [ath10k_pci]) from [<c062af3c>] (net_rx_action+0x138/0x2fc)
16:57:19 kernel: [212134.577304] [<c062af3c>] (net_rx_action) from [<c0301520>] (__do_softirq+0xe0/0x240)
16:57:19 kernel: [212134.586853] [<c0301520>] (__do_softirq) from [<c031b35c>] (irq_exit+0xd4/0x138)
16:57:19 kernel: [212134.594838] [<c031b35c>] (irq_exit) from [<c0352b24>] (__handle_domain_irq+0x9c/0xac)
16:57:19 kernel: [212134.602300] [<c0352b24>] (__handle_domain_irq) from [<c030140c>] (gic_handle_irq+0x5c/0x90)
16:57:19 kernel: [212134.610025] [<c030140c>] (gic_handle_irq) from [<c030b80c>] (__irq_svc+0x6c/0x90)
16:57:19 kernel: [212134.618610] Exception stack(0xc0a01f48 to 0xc0a01f90)
16:57:19 kernel: [212134.625992] 1f40: 00000001 00000000 00000000 c0313c60 ffffe000 c0a03c74
16:57:19 kernel: [212134.631118] 1f60: c0a03c28 00000000 00000000 c092da28 cfffcb00 00000000 c0a01f90 c0a01f98
16:57:19 kernel: [212134.639361] 1f80: c0308108 c030810c 60000013 ffffffff
16:57:19 kernel: [212134.647610] [<c030b80c>] (__irq_svc) from [<c030810c>] (arch_cpu_idle+0x34/0x38)
16:57:19 kernel: [212134.652737] [<c030810c>] (arch_cpu_idle) from [<c034986c>] (do_idle+0xdc/0x1a0)
16:57:19 kernel: [212134.660287] [<c034986c>] (do_idle) from [<c0349b8c>] (cpu_startup_entry+0x18/0x1c)
16:57:19 kernel: [212134.667752] [<c0349b8c>] (cpu_startup_entry) from [<c0900c94>] (start_kernel+0x3b8/0x3c4)
16:57:19 kernel: [212134.675259] ---[ end trace 6004b92667e9bf9f ]---
16:57:19 kernel: [212134.872082] IPv6: ADDRCONF(NETDEV_CHANGE): wlan1: link becomes ready
16:57:19 kernel: [212134.874435] br-lan: port 3(wlan1) entered blocking state
16:57:19 kernel: [212134.878243] br-lan: port 3(wlan1) entered forwarding state
16:57:19 netifd: Network device 'wlan1' link is up
16:57:19 hostapd: wlan1: interface state DFS->ENABLED
16:57:19 hostapd: wlan1: AP-ENABLEDThe line in the warning that ends with this: "alinux-ipq40xx/ath10k-ct-2018-12-20-118e16da/ath10k-4" should show a line number if it were not truncated. Can you check to see if you can get that full line out of dmesg or logread or something?
ynezz
commented
5 years ago Here it is
[212134.380357] ------------[ cut here ]------------
[212134.380532] WARNING: CPU: 0 PID: 0 at /var/lib/buildbot/slaves/slashdirt-03/MAIN/build/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/linux-ipq40xx/ath10k-ct-2018-12-20-118e16da/ath10k-4.19/htt_rx.c:903 ath10k_htt_t2h_msg_handler+0xf00/0x2530 [ath10k_core]
[212134.384909] Modules linked in: pppoe ppp_async ath10k_pci ath10k_core ath pppox ppp_generic nf_conntrack_ipv6 mac80211 iptable_nat ipt_REJECT ipt_MASQUERADE cfg80211 xt_time xt_tcpudp xt_state xt_nat xt_multiport xt_mark xt_mac xt_limit xt_conntrack xt_comment xt_TCPMSS xt_REDIRECT xt_LOG xt_FLOWOFFLOAD xt_CT slhc nf_reject_ipv4 nf_nat_redirect nf_nat_masquerade_ipv4 nf_conntrack_ipv4 nf_nat_ipv4 nf_nat nf_log_ipv4 nf_flow_table_hw nf_flow_table nf_defrag_ipv6 nf_defrag_ipv4 nf_conntrack_rtcache nf_conntrack iptable_mangle iptable_filter ip_tables hwmon crc_ccitt compat ledtrig_usbport ip6t_REJECT nf_reject_ipv6 nf_log_ipv6 nf_log_common ip6table_mangle ip6table_filter ip6_tables x_tables leds_gpio xhci_plat_hcd xhci_pci xhci_hcd dwc3 dwc3_of_simple gpio_button_hotplug
[212134.453336] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.14.94 #0
[212134.475462] Hardware name: Generic DT based system
[212134.481482] [<c030e774>] (unwind_backtrace) from [<c030ac9c>] (show_stack+0x10/0x14)
[212134.486159] [<c030ac9c>] (show_stack) from [<c072c248>] (dump_stack+0x88/0x9c)
[212134.494142] [<c072c248>] (dump_stack) from [<c03173e4>] (__warn+0xe4/0x100)
[212134.501260] [<c03173e4>] (__warn) from [<c03174b0>] (warn_slowpath_null+0x20/0x28)
[212134.508623] [<c03174b0>] (warn_slowpath_null) from [<bf2e71e8>] (ath10k_htt_t2h_msg_handler+0xf00/0x2530 [ath10k_core])
[212134.516064] [<bf2e71e8>] (ath10k_htt_t2h_msg_handler [ath10k_core]) from [<bf2e73b8>] (ath10k_htt_t2h_msg_handler+0x10d0/0x2530 [ath10k_core])
[212134.527137] [<bf2e73b8>] (ath10k_htt_t2h_msg_handler [ath10k_core]) from [<bf2e86b4>] (ath10k_htt_t2h_msg_handler+0x23cc/0x2530 [ath10k_core])
[212134.539723] [<bf2e86b4>] (ath10k_htt_t2h_msg_handler [ath10k_core]) from [<bf2e8ef0>] (ath10k_htt_txrx_compl_task+0x6cc/0xb78 [ath10k_core])
[212134.552541] [<bf2e8ef0>] (ath10k_htt_txrx_compl_task [ath10k_core]) from [<bf3382d4>] (ath10k_pci_napi_poll+0x70/0x100 [ath10k_pci])
[212134.565348] [<bf3382d4>] (ath10k_pci_napi_poll [ath10k_pci]) from [<c062af3c>] (net_rx_action+0x138/0x2fc)
[212134.577304] [<c062af3c>] (net_rx_action) from [<c0301520>] (__do_softirq+0xe0/0x240)
[212134.586853] [<c0301520>] (__do_softirq) from [<c031b35c>] (irq_exit+0xd4/0x138)
[212134.594838] [<c031b35c>] (irq_exit) from [<c0352b24>] (__handle_domain_irq+0x9c/0xac)
[212134.602300] [<c0352b24>] (__handle_domain_irq) from [<c030140c>] (gic_handle_irq+0x5c/0x90)
[212134.610025] [<c030140c>] (gic_handle_irq) from [<c030b80c>] (__irq_svc+0x6c/0x90)
[212134.618610] Exception stack(0xc0a01f48 to 0xc0a01f90)
[212134.625992] 1f40: 00000001 00000000 00000000 c0313c60 ffffe000 c0a03c74
[212134.631118] 1f60: c0a03c28 00000000 00000000 c092da28 cfffcb00 00000000 c0a01f90 c0a01f98
[212134.639361] 1f80: c0308108 c030810c 60000013 ffffffff
[212134.647610] [<c030b80c>] (__irq_svc) from [<c030810c>] (arch_cpu_idle+0x34/0x38)
[212134.652737] [<c030810c>] (arch_cpu_idle) from [<c034986c>] (do_idle+0xdc/0x1a0)
[212134.660287] [<c034986c>] (do_idle) from [<c0349b8c>] (cpu_startup_entry+0x18/0x1c)
[212134.667752] [<c0349b8c>] (cpu_startup_entry) from [<c0900c94>] (start_kernel+0x3b8/0x3c4)
[212134.675259] ---[ end trace 6004b92667e9bf9f ]---That code is the last warning in this method:
static struct ieee80211_channel ath10k_htt_rx_h_peer_channel(struct ath10k ar, struct htt_rx_desc rxd) { struct ath10k_peer peer; struct ath10k_vif *arvif; struct cfg80211_chan_def def; u16 peer_id;
lockdep_assert_held(&ar->data_lock);
if (!rxd)
return NULL;
if (rxd->attention.flags &
__cpu_to_le32(RX_ATTENTION_FLAGS_PEER_IDX_INVALID))
return NULL;
if (!(rxd->msdu_end.common.info0 &
__cpu_to_le32(RX_MSDU_END_INFO0_FIRST_MSDU)))
return NULL;
peer_id = MS(__le32_to_cpu(rxd->mpdu_start.info0),
RX_MPDU_START_INFO0_PEER_IDX);
peer = ath10k_peer_find_by_id(ar, peer_id);
if (!peer)
return NULL;
arvif = ath10k_get_arvif(ar, peer->vdev_id);
if (WARN_ON_ONCE(!arvif))
return NULL;
if (WARN_ON_ONCE(ath10k_mac_vif_chan(arvif->vif, &def)))
return NULL;
return def.chan;}
I am guessing this is not a real problem, and it looks like the ath10k_htt_rx_h_channel method expects it can fail and deals with it.
ynezz
commented
5 years ago Just an update, OpenWrt snapshot r9086-8c9b182 from Mon Jan 21 15:35:40 2019 and 10.4b-ct-4019-fW-012-c2d65911 has been running stable for 6 days and 17 hours so far :+1:
ynezz
commented
5 years ago Just an update, OpenWrt snapshot r9086-8c9b182 from Mon Jan 21 15:35:40 2019 and 10.4b-ct-4019-fW-012-c2d65911 has been running stable for 14 days and 16 hours so far :+1:
Thanks!
OpenWrt SNAPSHOT r8997-488af51fromSun Jan 6 20:48:11 2019