greearb / ath10k-ct

Stand-alone ath10k driver based on Candela Technologies Linux kernel.
111 stars 41 forks source link

QCA988X ASPM L1 state fix #76

Closed psyborg55 closed 5 years ago

psyborg55 commented 5 years ago

this change was adapted from ath9k patch, and it solves the issue of device crash when using default kernel config. more details>https://patchwork.kernel.org/patch/2849305/

greearb commented 5 years ago

Have you actually tested this patch, and do you have any system that reproduces the problem reported (and is seen to be fixed by this patch)?

psyborg55 commented 5 years ago

Yes, I build kernel for my notebook and until figured out I need to set CONFIG_PCIEASPM_PERFORMANCE=y card would crash everytime, no matter if using ct or upstream driver/fw. With this patch it works fine with CONFIG_PCIEASPM_DEFAULT=y which is default kernel option (ASPM from BIOS). Hardware is QCA9862.

greearb commented 5 years ago

I automatically pull in ath10k-ct from my *-ct kernels into ath10k-ct, so I'll apply the patch to my kernels and merge it into ath10k-ct that way. If you want credit in git, please make a pull request against those repos instead of ath10k-ct. Either way, thanks for the heads up on this patch.

psyborg55 commented 5 years ago

No problem, commit as you wish. I've sent a patch for upstream driver to mailing list.