Closed yosukesan closed 2 years ago
Stop merging a bit. I forgot to pass pep8.
I misread the message. I think the patch is ready to merge. Just for note, I got following message. Probably better to switch pycodestyle or other linter, such as pyplakes, in test.
To fix E712, I can send another patch if you don't mind. Probably it's better to make another issue.
$ pep8
/home/yosuke/.local/lib/python3.7/site-packages/pep8.py:110: FutureWarning: Possible nested set at position 1
EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]')
/home/yosuke/.local/lib/python3.7/site-packages/pep8.py:2124: UserWarning:
pep8 has been renamed to pycodestyle (GitHub issue #466)
Use of the pep8 tool will be removed in a future release.
Please install and use `pycodestyle` instead.
$ pip install pycodestyle
$ pycodestyle ...
'\n\n'
./tests/xbrl.py:704:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
./xbrl/xbrl.py:704:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Result follows. Test environment is identical to #53.