Server Crash Bug

[GoogleCodeExporter]

I am using RunUO Mondains 64bit.

I think I have stumbled on a flaw that results in Server Crashes when using the 
Peerless Altars.

Here are some of the comments I received from the RunUO peer group:

*************************************************************************
RandomTalisman():
talisman.Summoner = BaseTalisman.GetRandomSummoner();
if ( talisman.Summoner.IsEmpty )"

GetRandomSummoner() method is invoked and the property IsEmpty is checked of 
the instance it returns to you. In it returns null you will have NullReference 
crash.

GetRandomSummoner():
"if ( 0.925 > Utility.RandomDouble() )
{
    ...
}
return null;

"The GetRandomSummoner() method has 0.925 chance to return you something and 
0.075 chance to return you null. So you'll get server crash in 75/1000 cases. 
Ouch, 7.5% to get a crash, that's BAD! I don't know why it was designed that 
way but suggest to perform "talisman.Summoner != null" check before you try to 
reference its properties."
*************************************************************************
"Whom ever created this script did it the hard way for many things, like 
redoing all the aos props when they did not neeed to, etc
Not sure where you got it from, or where they got it from, but it needs a lot 
of rework"
*************************************************************************
"I suggest that you report this issue just in case nobody else noticed it."
*************************************************************************

Original issue reported on code.google.com by scubacl...@gmail.com on 10 Aug 2010 at 1:30

[GoogleCodeExporter]

That is actually MalGanis's code.  And he as been working with RunUO Devs to 
incorporate them into RunUO SVN.  There hase been progress and I have been 
waiting to see if they are going to make it live or not.  There are files with 
which I am looking at to see if they are viable to add to my svn.  If they 
delete the talismans I'll have to do some modifying.

Original comment by ShaiTanMalkier@gmail.com on 6 Sep 2010 at 4:52

• Changed state: Started

[GoogleCodeExporter]

I am using RunUO Mondains 64bit.

the sever seems to reboot whenever someone gets to the 3 or 4th screen of 
sanctuary in trammel. I can't figure out why.

Original comment by Tani...@gmail.com on 14 Sep 2010 at 3:35

[GoogleCodeExporter]

"the sever seems to reboot whenever someone gets to the 3 or 4th screen of 
sanctuary in trammel. I can't figure out why."

I had that problem too and fixed it. There is one spawn creature there that has 
to be deleted. Sorry I cannot remember which one but there is only one. I had 
to come in through the tunnels then go over the fence and very slowly walk back 
toward the entrance watching Journal for the name of the creature last seen 
befor the crash. Then I was able to find the spawner and delete him from it 
before I was close enough to where he spawned to cause another crash. Sorry - 
best I can do.

Original comment by scubacl...@gmail.com on 14 Sep 2010 at 4:11

[GoogleCodeExporter]

i found the spawner it is the orcscout

Original comment by Tani...@gmail.com on 14 Sep 2010 at 11:37

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

The Orc Scout still giving problems?

What are the coordinates for the spawner that is crashing the server?

Can you give crash log in debug mode for exact error that is happening upon 
crash?

Original comment by ShaiTanMalkier@gmail.com on 15 Sep 2010 at 1:39

[GoogleCodeExporter]

Original comment by ShaiTanMalkier@gmail.com on 8 Dec 2010 at 5:12

• Changed state: Done