greedyj4ck / DEGENESIS-FoundryVTT

DEGENESIS: Rebirth system for Foundry Virtual Tabletop
26 stars 22 forks source link

Roll settings: Modifiers not applied when pressing ENTER #137

Closed Dentatum closed 7 months ago

Dentatum commented 7 months ago

Not sure if this is more like a feature request, but modifiers only work when clicking on "Roll" button after setting them up. Could this also be programmed to be applied when ENTER is pressed?

Im talking about this menu. Currently, when hitting enter, it rolls without modifiers: image

greedyj4ck commented 7 months ago

Does pressing Enter triggers roll without modifiers or does nothing at all ?

I think I can add keyOn event listener to confirm roll.

Dentatum commented 7 months ago

It rolls without modifiers, editing op

greedyj4ck commented 7 months ago

Will look into that.

greedyj4ck commented 7 months ago

@Dentatum Roll parameters are getting updated on input value change event, which is triggered after input element loose focus. Its a simply fix. For now you can add this one liner to roll-dialog.js

image

Fix will be implemented in next major release ;)