greedyj4ck / DEGENESIS-FoundryVTT

DEGENESIS: Rebirth system for Foundry Virtual Tabletop
26 stars 22 forks source link

Mod not reflected in combat values #65

Closed mhiner closed 2 years ago

mhiner commented 2 years ago

I created a modification item for handling and set it with the key handling => add => 1

I then added the item to a weapon. In the inventory section of the actor the description shows the added handling correctly, along with the other attributes. If I add the handling mod a second time it increments the value a second time.

Under combat however the value for attack dice only includes the handling value for the base weapon.

greedyj4ck commented 2 years ago

Newest version or v9?

mhiner commented 2 years ago

newest version. The install of both Foundry and add-on are less than 36 hours old. (Working my way through testing things and learning the platform)

I took a marvel, added 1 to handling by quality (to make sure that it recognized the attribute) and 2 handling mods (to make sure it was not ignoring only the first mod) giving a handling of +3D

Marvel Display

The mod itself

handling_mod

The test char has a base 6 for projectlies

attibutes

but the combat tab only lists 7D

combat

Version info

version

greedyj4ck commented 2 years ago

Thanks, will check it out.

greedyj4ck commented 2 years ago

Found the culprit - apply mods function is firing after preparing data for weapons (calculating AN).

greedyj4ck commented 2 years ago

Changed order of executing functions, seems to be working properly now. Fix will appear with the release of 0.5.1