search

green-anger / GlobeViewer

View popular online maps in Orthographic projection
MIT License
10 stars 6 forks source link

Signal mapReady readability can be improved #53

Closed green-anger closed 5 years ago

green-anger commented 5 years ago

DataKeeper always sends true and MapGenerator always sends false. There's no need for them to have any parameters. It can be handled at GlobeViewer::Impl level. It can help to rename signal to "mapNotReady" for MapGenerator. Documentation must reflect the change.