Rule EC66 does not apply to the Python language

green-code-initiative / creedengo-python

Reduce the environmental footprint of your Python software programs

https://green-code-initiative.org/

GNU General Public License v3.0

7 stars 9 forks source link

Rule EC66 does not apply to the Python language #4

Closed dedece35 closed 11 months ago

dedece35 commented 1 year ago

please check the analysis done in closed issue in old repository : https://github.com/green-code-initiative/ecoCode/issues/198 existing rule in SonarQube : quite the same subject => "python:S3457"

TO DISCUSS INSIDE CORE_TEAM : opinion ? I'm ok with analysis (Python expert)

dedece35 commented 1 year ago

after discussion with core-team :

"python:S3457" is not the same subject
@jhertout will see it and we will come back here with idea
if no idea, next @dedece35 will check deeply the given analysis

jhertout commented 1 year ago

Hello, I perform some investigation and I confirm the analysis done in https://github.com/green-code-initiative/ecoCode/issues/198. I cannot see differences in the bytecode too and when going through the python documentation they explicitly say that they can be used indifferently.

I think we can remove this rule for Python. It is not an "instinctive rule" for Python and the documentation and first impression are likely to show that there are no differences. For me, if this rule is true, measures MUST be done because without them, everything seems to indicate there is no differences.

dedece35 commented 1 year ago

Hi @jhertout, thank you for analysis. ok, I will remove this rule for python and I will create a new MD file to reference this kind of work which must be done. (plop @glalloue )

dedece35 commented 11 months ago

deprecation of EC66 rule done in PRs :

ecocoderepo : https://github.com/green-code-initiative/ecoCode/pull/261
ecocode-python repo : https://github.com/green-code-initiative/ecoCode-python/pull/9