search

green-code-initiative / ecoCode-android

Reduce the environmental footprint of your Java-based Android apps with SonarQube
https://ecocode.io
GNU General Public License v3.0
54 stars 17 forks source link

Upgrade some versions + sonar version from 9.3 to 9.8 #13

Closed oussamaLaribi closed 1 year ago

dedece35 commented 1 year ago

Hi @oussamaLaribi , I made few minutes ago a refactoring / optimization on pom.xml files : there were some mistakes on scopes on dependencies. Please, update your branch with my modifications. I think you will have some conflicts, be carefull.

Then you can delete "compile" because it is the default scope on your dependency sonar-plugin-api-impl

oussamaLaribi commented 1 year ago

Hi @oussamaLaribi , I made few minutes ago a refactoring / optimization on pom.xml files : there were some mistakes on scopes on dependencies. Please, update your branch with my modifications. I think you will have some conflicts, be carefull.

Then you can delete "compile" because it is the default scope on your dependency sonar-plugin-api-impl

Hi @dedece35, Okay I'll do it. Thanks.

oussamaLaribi commented 1 year ago

Hi, @dedece35. It's ready for review.

oussamaLaribi commented 1 year ago

Hi @oussamaLaribi, I'm ok with this PR. But can you report your corrections about plugin maven-shade to correct WARNINGs during build phase, please ?

Hi @dedece35, Okay I'll do it. Thanks.