search

green-code-initiative / ecoCode-android

Reduce the environmental footprint of your Java-based Android apps with SonarQube
https://ecocode.io
GNU General Public License v3.0
57 stars 17 forks source link

minSdk and targetSdk properties must be supported too #4

Closed dedece35 closed 1 year ago

dedece35 commented 1 year ago

This detection rule triggers on minSdkVersion and targetSdkVersion but their variants minSdk and targetSdk are ignored. This has to be fixed.

initial PR (before migration): https://github.com/cnumr/ecoCode/pull/178 (plop @olegoaer )

jhertout commented 1 year ago

Done in PR https://github.com/green-code-initiative/ecoCode-mobile/pull/28

dedece35 commented 1 year ago

@jhertout @olegoaer @Jberque now, can I create the release 1.0.0 of android and iOS plugin ?

@jhertout @olegoaer We can delete the branch of this PR. no ? (button "delete branch" bottom)

jhertout commented 1 year ago

For me you can create the 1.0.0. Wait for @olegoaer answer to be sure.

olegoaer commented 1 year ago

go-ahead 🚀