search

green-code-initiative / ecoCode-android

Reduce the environmental footprint of your Java-based Android apps with SonarQube
https://ecocode.io
GNU General Public License v3.0
58 stars 18 forks source link

Improve rule EC5002 (SDK range) description #78

Closed jhertout closed 12 months ago

jhertout commented 12 months ago

As mentioned by Ann here: https://community.sonarsource.com/t/new-plugin-ecocode-android-requesting-inclusion-in-sonarqube-marketplace/104674/3 the description of this rule is not very clear :

When looking at the minSdkVersion and targetSdkVersion (or minSdk, targetSdk) attributes for the <uses-sdk> in the AndroidManifest.xml file, the amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases. -> "too heavy to handle all cases." is not very understandable.

We must clarify this rule. @olegoaer an idea?

olegoaer commented 12 months ago

I'm not a big fan of this rule any more, as it's still vague. I was planning to remove it from the catalogue.

jhertout commented 12 months ago

OK, in this case we can wait until we remove it. Do we create an issue to remove the rule and close this one?

olegoaer commented 12 months ago

Note that the up-to-date, Sonar-independant description of Android rules is on https://github.com/cnumr/best-practices-mobile

SDK range rule no more exist A new category was introduced: longevity ;)

jhertout commented 12 months ago

OK, I did not see that. I close this issue and add one to remove the rule.