search

green-code-initiative / ecoCode-ios

Reduce the environmental footprint of your Swift-based iOS apps with SonarQube
https://ecocode.io
GNU General Public License v3.0
4 stars 5 forks source link

refactor: Uses standard org.sonar.check.Rule annotation #16

Closed jycr closed 7 months ago

jycr commented 1 year ago

fix: #15

dedece35 commented 1 year ago

Hi @jycr, before all, could you correct the build / test errors please ?

jycr commented 1 year ago

Hi @jycr, before all, could you correct the build / test errors please ?

@dedece35 : I don't think this SonarCloud analysis is a problem of my PR, but a problem in repo configuration? Isn't it?

Error: Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar (default-cli) on project ios-plugin: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar (default-cli) on project ios-plugin: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator

github-actions[bot] commented 11 months ago

This PR has been automatically marked as stale because it has no activity for 30 days. Please add a comment if you want to keep the issue open. Thank you for your contributions!

zippy1978 commented 7 months ago

Hi @dedece35 , @jycr, As I need to merge this refact soon, I did address the comments of this one and issued a new PR here : https://github.com/green-code-initiative/ecoCode-ios/pull/20

So you can close this one, and review the new one instead.

dedece35 commented 7 months ago

Hi @zippy1978, as you wanted, PR closed.