search

green-code-initiative / ecoCode-ios

Reduce the environmental footprint of your Swift-based iOS apps with SonarQube
https://ecocode.io
GNU General Public License v3.0
4 stars 5 forks source link

Use Java 17 for the SonarQube scan #17

Closed utarwyn closed 8 months ago

utarwyn commented 9 months ago

Duplicate of https://github.com/green-code-initiative/ecoCode/pull/229

Sorry for the redundant PR but I can't push to main branch on this plugin, @dedece35 you know why?

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

utarwyn commented 8 months ago

@dedece35 any news on this? also about permissions?

dedece35 commented 8 months ago

@dedece35 any news on this? also about permissions?

I checked rigths and core-team have "maintener" rigths. You are in "core" team. But no PR could be merged directly without at most one reviewer. If you want to do this anyway, you have to check the checkbox "merge without waiting for requirements to be met", and then click on "merge pull request". Do you have this checkbox and this button ? We could discuss about it directly next week if you want.

utarwyn commented 8 months ago

Seen with @dedece35, I now have the checkbox. Thank you!