Process feedbacks after plugin submission to SonarQube marketplace

[utarwyn]

Plugin has been submitted to the SonarQube Marketplace!

Even though the request was accepted (🥳), there are a few improvements to be made to the plugin for future versions. Here are the suggestions proposed by Ann:

• [x] It looks like all your rules have been classed as Consistency/Conventional in the new Clean Code taxonomy. I’m (now) assuming that’s the default. Just a note that in future releases you may want to take a look at this.
• [x] One thing I’m not seeing is // Noncompliant comments in your noncompliant code samples. They help users separate the wheat from the chaff
• [x] ecocode-javascript:EC24 - I’m surprised this rule recommends a limit and not a where clause. I would think limiting CPU at the server / DB would be in scope here :slight_smile:
• [x] I see that a few rules provide Further Reading, which is awesome. And there’s a way to mark that up to have it shown on a ‘More Info’ tab, E.G.. I’m not aware of the details, but if you want to create a thread, we can get it tracked down.
• [x] ecocode-javascript:EC12 - “There are more than two style assignations for ‘element’. Use a class instead.” ↪️ Use "assignments" instead

[utarwyn]

I have integrated all feedbacks in following commits:

• https://github.com/green-code-initiative/ecoCode-javascript/commit/2932bc988c4d0d24ed8170091d4ccaeceeae770d
• https://github.com/green-code-initiative/ecoCode/commit/5ed903a9ed9ddf9b36ff23a14974457be39f1bc5
• https://github.com/green-code-initiative/ecoCode/commit/e52fd183de115997da7bbe2d7b320e88c4f8f0dc

We have to wait for a new version of rules specification artifact in order to integrate them in the next version of the plugin. Changelog has been adapted accordingly :+1: