search

green-coding-solutions / eco-ci-energy-estimation

Eco CI Energy estimation for Github Actions Runner VMs
MIT License
48 stars 10 forks source link

fix: non-formatted details of old measurements #55

Closed jreimone closed 6 months ago

jreimone commented 6 months ago

The <detail> view of old measurements is not formatted correctly. This is reproduced in this PR: https://github.com/jreimone/public-reproduction/pull/3

dan-mm commented 6 months ago

Thank you for the contribution, but I've already tackled this issue in this PR: https://github.com/green-coding-berlin/eco-ci-energy-estimation/pull/53#pullrequestreview-1759494618

Unfortunately just sending the newlines in the payload like that didn't format the message correctly during my testing (my first attempt at fixing this looked identical to yours). Sending actual newlines is the only thing that worked for me. Bash can be weird sometimes.

jreimone commented 6 months ago

Cool, thank you