green-coding-solutions / green-metrics-tool

Measure energy and carbon consumption of software
https://metrics.green-coding.io
GNU Affero General Public License v3.0
175 stars 23 forks source link

Error logging - moving away from email #473

Open ArneTR opened 1 year ago

ArneTR commented 1 year ago

Since we already have a file logging implemented in the https://github.com/green-coding-berlin/green-metrics-tool/blob/main/lib/error_helpers.py we should:

Currently every failure in the API takes a lot of processing time. So even pushing to a remote service would create quite some load.

The filesystem solution decouples it completely.

Our implementation to have then again email, but async, could be using swatch

ribalba commented 1 year ago

What about we implement https://docs.python.org/3/library/logging.html . This is something I have had on my todo for some time. We could implement logging for the runner and the server and such have a unified api. We could also start the server/ runner in debug mode to see what is happening, if we need to and otherwise reduce the "clutter" a little.

ArneTR commented 1 year ago

yes, can be done. We can just swap it for the standard library to make it more semantic / obvious for frequent Python users.

The logging is already centralized and unified in server and CLI though, so from a functional perspective I see no uptake ... but still agree to do it once we tackle it.