search

greena13 / react-hotkeys

Declarative hotkey and focus area management for React
https://github.com/greena13/react-hotkeys
ISC License
2.15k stars 160 forks source link

[BUG] stopEventPropagationAfterIgnoring: false leads to Ctrl+E only being matched when pressed in reverse (E+Ctrl) #260

Open Nantris opened 4 years ago

Nantris commented 4 years ago

Describe the bug E+Ctrl matches, but Ctrl+E does not match - only with stopEventPropagationAfterIgnoring: false

How are you using react hotkeys components? (HotKeys, GlobalHotKeys, IgnoreKeys etc) <GlobalHotKeys />

Expected behavior Ctrl+E should be caught and fire the handler. Instead, only the following are caught:

or

  1. Press and hold Ctrl+E
  2. Release E
  3. Press E again

Platform (please complete the following information):

Are you willing and able to create a PR request to fix this issue?

No

What Configuration options are you using?

  configure({
    ignoreEventsCondition: evt => false,
    stopEventPropagationAfterIgnoring: false,
  });
greena13 commented 4 years ago

Thanks for posting your issue.

Unfortunately I do not have the time to actively work on this package, but I am seeking other active maintainers. If you are willing to create a pull request or help out, that would be an excellent way of moving this forward.