greena13 / react-hotkeys

Declarative hotkey and focus area management for React
https://github.com/greena13/react-hotkeys
ISC License
2.15k stars 160 forks source link

[BUG] Mousetrap Mod identifier not working #273

Open AkalUstat opened 4 years ago

AkalUstat commented 4 years ago

Describe the bug A clear and concise description of what the bug is. In mousetrap, there is the mod keyword that maps to Command and Ctrl for macos and windows respectively. This doesnt work for react-hotkeys for some reason. How are you using react hotkeys components? (HotKeys, GlobalHotKeys, IgnoreKeys etc) Using HotKeys Component Expected behavior A clear and concise description of what you expected to happen. using mod would map to cmd on mac and ctrl on windows Platform (please complete the following information):

Are you willing and able to create a PR request to fix this issue? depending on complexity (don't have much time due to school) Include the smallest log that includes your issue:


  toggleSettings: {
     name: 'Toggle Settings',
     sequence: 'mod+e',
   },`
``
nothing happens with above snippet

**What Configuration options are you using?**
Default config