search

greena13 / react-hotkeys

Declarative hotkey and focus area management for React
https://github.com/greena13/react-hotkeys
ISC License
2.15k stars 160 forks source link

[REQUEST FOR COMMENT] Community Takeover (Fork) 9/18 #289

Open PatrickDesign opened 4 years ago

PatrickDesign commented 4 years ago

Summary There have been many attempts to pass on the ownership of this package to new maintainers as seen in our own README as well as (https://github.com/greena13/react-hotkeys/issues/247). There have also been calls for a community takeover on r/react. All of these requests for assistance have been met with people who are readily available to help maintain the project.

Describe the solution you'd like With cooperation from the community, I propose that if we do not hear back from @greena13 by Friday, September 18th (2020), we perform a community takeover by forking the project. We can then start making headway on the current open PRs and issues. I also propose that we come up with a new name for the npm registry together. I was thinking react-keyboard-shortcuts but that's already taken.

Additional context Attempts to contact the author via LinkedIn & Twitter have been made, but have so far been unsuccessful.

greena13 commented 4 years ago

Hi @PatrickDesign,

Thanks for your eye-catching subject line. It saved me from missing this.

No community takeover is necessary. I'm in full agreeance this package needs new ownership. I don't currently have time to even keep a particularly close eye on the issues being filed (which is why I've struggled to sync up any previous offer to take ownership).

If one or more individuals are willing to take responsibility for react-hotkeys and are able to demonstrate the capacity and ability to do so, I'm happy to share or transfer ownership.

PatrickDesign commented 4 years ago

🎉 This is great news! (and obviously less work..)

I am in contact with a few people who are interested in joining me in maintaining the project. Hopefully they jump in this thread :).

greena13 commented 4 years ago

That is equally encouraging.

Out of curiosity - I have obviously lost touch - what do you see being the low hanging fruit and areas of primary concern? What would a short-term roadmap look like in your mind?

I'm aware there is a lot to go through and triage in the issues.

PatrickDesign commented 4 years ago

I was thinking something like this 💭

Short term roadmap (essential bugfixes which will hopefully restore all core functionality):

Low hanging:

Requested features that should be implemented as soon as they can be worked on:

greena13 commented 4 years ago

Sounds sensible to me. 👍

I've added you as a contributor. I'll figure out the next steps, when you have something you think is in a state to release.

Let me know if I can be of any further help.

Harjot1Singh commented 4 years ago

I would put in some PRs if someone was actively merging/maintaining, so do ping this thread whenever this is the case @PatrickDesign.

wilsongp commented 4 years ago

I'd also like to contribute when activity spins back up! I'll poke around the high-priority bugs in the meantime.

nopol10 commented 4 years ago

Not sure if I should start a new issue but is there any chance for the the highest priority item to be to update the package published in npm to match the latest commit in this repository? I have encountered a major bug in 2.0.0 (pressing spacebar stops all hotkeys from functioning until a refocus) that does not occur if I build and use the one in this repo.

ibash commented 3 years ago

Forked: https://github.com/ibash/react-hotkeys Publishing under "react-hotkeys-ce". (ce is for community edition) I just published the master branch as v2.0.1

If anyone wants to submit pull requests or be a collaborator, just ping me and I'll add you. Feel free to email me to: islam.sharabash@gmail.com

ibash commented 3 years ago

I'm publishing fixes: https://github.com/ibash/react-hotkeys

R4VANG3R commented 3 years ago

Any update on the "takeover"? I see there's a fork now, but what's the status from the new Ownership?

ibash commented 3 years ago

Submit a pr and I’ll merge it, but I’m not actively using react-hotkeys

CAMAINElie commented 2 years ago

Hi here,

I am currently using this library and would need a few fixes, I am willing to do them myself but would like to know first if it would be used/merged ! Is there still someone in charge here ?

ibash commented 2 years ago

Is there still someone in charge here ?

No, not really.

I'm happy to take PRs on my fork and publish them. (https://github.com/ibash/react-hotkeys) and/or just add you as a maintainer there, but I'm not actively using the library, so not actively fixing bugs.

More recently I've been using tinykeys which is pretty nice: https://github.com/jamiebuilds/tinykeys