search

greenaddress / WalletCrx

GreenAddress open source client
https://greenaddress.it/
GNU Lesser General Public License v2.1
79 stars 39 forks source link

Remove keepkey from the manifest #20

Closed bgok closed 8 years ago

bgok commented 8 years ago

Since KeepKey isn't working and it appears that the supporting code was removed, can we remove it from the manifest? It potentially creates conflicts with the KeepKey chrome application.

Thanks.

greenaddress commented 8 years ago

The code removed is only for the web version not for the Chrome app, what was removed from the Chrome app is the ledger firmware update as the ledger app does that better.

Last time I tried KeepKey worked for me but I'll try it again as soon as i get a chance.

bgok commented 8 years ago

I stepped through the version detection code and the keepkey condition isn't there. I though it was an intentional change. I found where it was added, but it isn't there any more. Was it refactored into another repository?

greenaddress commented 8 years ago

@bgok indeed the code was removed but it was by accident during a merge (i think it happened during some refactoring). We are currently working on improving and abstracting some wallet interfaces and will integrate back in KeepKey support as part of it

sorry for the confusion and misleading manifest

bgok commented 8 years ago

Cool. I added code to the KK chrome extension to silently disable GA when a KeepKey plugged in. Once you get it working again, I'll make the code a little smarter and give a warning to the user.

Please let me know when you have it working again. Thanks!

Ken@keepkey.com