greenaddress / abcore

ABCore - Android Bitcoin Core

http://abco.re

MIT License

164 stars 55 forks source link

Adding some UX improvements #81

Closed jjyy21 closed 5 years ago

jjyy21 commented 5 years ago

Adding toolbars to all Activites (except Settings and Peers. This is forthcoming along with a refactor to avoid code duplication of the menu bar in multiple activities)
Displaying the daemon that is being used in the toolbar
Naming the landing screen as Dashboard

Tested in "Pixel 2 API 29" emulator and Galaxy S9

udiWertheimer commented 5 years ago

Thanks for this PR, @johnyukon21! Seeing as this is a UI change, could you please add some screenshots so that I can see what this should look like?

jjyy21 commented 5 years ago

Thanks for this PR, @johnyukon21! Seeing as this is a UI change, could you please add some screenshots so that I can see what this should look like?

Screen Shot 2019-07-01 at 7 30 48 PM Screen Shot 2019-07-01 at 7 31 09 PM Screen Shot 2019-07-01 at 7 33 15 PM

RCasatta commented 5 years ago

ack https://github.com/greenaddress/abcore/pull/81/commits/e10a48c6041d87113abb7f38d12b66d5e8d2498b

lvaccaro commented 5 years ago

ack e10a48c6041d87113abb7f38d12b66d5e8d2498b

jjyy21 commented 5 years ago

@lvaccaro @RCasatta Thanks for looking at the PR!

RCasatta commented 5 years ago

84 has been merged through #85 and includes this one, closing