greenaddress / garecovery

GreenAddress recovery tool for 2of2 and 2of3 wallets
MIT License
107 stars 53 forks source link

Passphrase support #47

Open rc-fire opened 2 years ago

rc-fire commented 2 years ago

Is there any way to use this tool for recovery (2 of 2) if the wallet used a passphrase (as supported by jade wallet since 2021-10-20) with a 12 or 24 word seed?

I don't see a passphrase anywhere mentioned in the docs or source, and the last update was 5 moths ago.

By the mess you made with the passphrase implementation on the jade hardware wallet there will soon be a lot of people needing to recover their passphrases systematically. As explanation: The wallet only requires you to type the passphrase once, this leaves room for typos. Other wallets (like Trezor) especially let you enter the passphrase 2 times - and if they detect an unused wallet give you a warning and even want a third entry of the passphrase.

JamieDriver commented 2 years ago

The tool does accept seed hex (suffixed with an 'X' - in place of mnemonic), so if you were using eg. a trezor and were using passphrase, this is how you'd do the recovery. (ie. derive the seed from mnemonic + passphrase externally, and pass the seed as hex into the tool).

However - your point is fair, especially since Jade supports passphrase, so I have added the option to pass any passphrase in, similar to mnemonic (ie. via a file, or via console entry).

If you want to discuss the details of passphrase entry on the Jade hw, please raise an issue in the Jade repo.

Many thanks.