search

greenape / mknotebooks

A plugin for mkdocs to help you include Jupyter notebooks in your projects
MIT License
136 stars 20 forks source link

ImportError: cannot import name '_RelativePathExtension' from 'mkdocs.structure.pages' #1100

Closed Lucas-C closed 1 year ago

Lucas-C commented 1 year ago

Hi,

This import is now invalid: https://github.com/greenape/mknotebooks/blob/master/mknotebooks/plugin.py#L17

This changed in PR https://github.com/mkdocs/mkdocs/pull/3283 that was released in mkdocs 1.5.0 last week.

I have just discovered that in this GitHub Actions pipeline exection: https://github.com/PyFPDF/fpdf2/actions/runs/5731678301/job/15533085644

CribberSix commented 1 year ago

Same here. Removed the plugin from our repositories for the time being.

Lucas-C commented 1 year ago

Yes, I also had to disable mknotebooks for now: https://github.com/PyFPDF/fpdf2/blob/master/mkdocs.yml#L54

SoumayaMauthoorMOJ commented 1 year ago

Same here from https://github.com/ministryofjustice/mkdocs-tech-docs-template

greenape commented 1 year ago

This should now be fixed.

CribberSix commented 1 year ago

This is great news! Thank you so much!

Lucas-C commented 1 year ago

Thank you @greenape, I confirm that this is now fixed for my use-case 👍