greenart7c3 / Amber

MIT License
119 stars 7 forks source link

F-Droid inclusion #12

Closed RasheedAZ closed 3 months ago

RasheedAZ commented 6 months ago

Hi. Thanks for creating this useful app. Are you open to it being submitted to F-Droid?

If you support reproducible builds, I think that simplifies the process.

https://reproducible-builds.org/

greenart7c3 commented 6 months ago

Thanks, will look into making it reproducible

greenart7c3 commented 4 months ago

I think the latest pre release is reproducible now. Can you test it? Would make some documentation on how to compile help too? like signal does. I also created some build flavors now because i needed push notifications for a feature, so for fdroid you should use the free flavor

./gradlew clean assembleFreeRelease
RasheedAZ commented 3 months ago

I was trying to test amber-free-arm64-v8a-v1.0.6.apk

How is this meant to work? Is a popup supposed to show up when trying to login to a client or post a note?

Does it need any permissions other than notifications?

greenart7c3 commented 3 months ago

You can download amethyst and when login in there's a login with amber button To test web clients you can use nostrudel.ninja and in the login there's an advanced option and there's a nostr connect/bunker button Before using nostrudel go to amber in the permissions screen press the new app button and copy the bunker url into noStrudel webpage. This will show a notification to connect to noStrudel

RasheedAZ commented 3 months ago

Oh ok never saw that on Amethyst as I've never logged out or used another profile. Just tested successfully on Amethyst. Will try a web client now

RasheedAZ commented 3 months ago

This will show a notification to connect to noStrudel

This notification didn't show so I just went back and clicked "Use Amber" and it worked.

greenart7c3 commented 3 months ago

Amber was approved in fdroid and will be available in a few days

https://gitlab.com/fdroid/fdroiddata/-/merge_requests/15219

licaon-kter commented 2 months ago

you tagged https://github.com/greenart7c3/Amber/tree/v1.1.0-pre1 but its versionName does not match the tag name https://github.com/greenart7c3/Amber/blob/v1.1.0-pre1/app/build.gradle#L19

so when F-Droid tries to build it and find its reproducible APK... it can't https://gitlab.com/fdroid/fdroiddata/-/jobs/7263225161#L467

do you want prereleases built?

greenart7c3 commented 2 months ago

I think there's no need for pre release in fdroid, can you filter this?

licaon-kter commented 2 months ago

we can, but you need to decide on a pattern and stick to it

how shall we recognize prereleases exactly?

fyi, the "pre release" thing that Github shows is unusable

so we are limited to the actual tag name, eg. pickup 1.2.3 but skip 1.2.3-alpha or 1.2.3-pre5

greenart7c3 commented 2 months ago

I use 1.2.3-pre$number you can ignore the ones with -pre and pick only when there's only 1.2.3

licaon-kter commented 2 months ago

done https://gitlab.com/fdroid/fdroiddata/-/commit/ef0912f1d52a1f3531e0674b9341167ba07cdeee