greenbender / pynntp

Python NNTP Library (supports compression)
GNU General Public License v3.0
19 stars 4 forks source link

`pip install "pynntp[tests]"` for running the tests on other repos #56

Open cclauss opened 1 week ago

cclauss commented 1 week ago

GitHub Actions in these repos run the pynntp tests against an INN2 server to ensure compatibility. pypnp does not ship with its tests so this currently requires:

      - uses: actions/checkout@v4
        with:
          repository: greenbender/pynntp
      - uses: actions/setup-python@v5
        with:
          python-version: '3.x'
      - run: pip install --upgrade pip
      - run: pip install pytest
      - run: pip install --editable .
      - run: pytest

Would it be possible to create a pip install "pynntp[tests]" option that would shorten this to:

      - uses: actions/setup-python@v5
        with:
          python-version: '3.x'
      - run: pip install --upgrade pip
      - run: pip install "pynntp[tests]" pytest
      - run: pytest
greenbender commented 1 week ago

I've looked into doing this, but it's not that straightforward.

After giving it some thought I'm also not sure it's the right approach to take for testing the docker image. By that I mean using pynntp client for testing is ok, but using the tests directly from the pynntp project is perhaps not ideal.