search

greenbone / docs

Documentation for the Greenbone Community Edition
https://greenbone.github.io/docs/
Creative Commons Attribution Share Alike 4.0 International
23 stars 32 forks source link

Change: Install latest docker-compose #368

Closed n-thumann closed 1 year ago

n-thumann commented 1 year ago

What

This PR changes the install guide for docker-compose to use the latest release instead of the Debian / Ubuntu package or the one from PyPi.

Why

The final Compose V1 release, version 1.29.2, was May 10, 2021. These packages haven't received any security updates since then. Use at your own risk. (from https://docs.docker.com/compose/migrate/). Both the Debian / Ubuntu package and the PyPi package contain Compose v1, which we shouldn't recommend using any more (Note: Compose v2 will be available for the upcoming Ubuntu 23.10 as docker-compose-v2).

Possible approaches:

  1. Use Compose v2 as a plugin of Docker by installing docker-compose-plugin. This requires to use use the official Docker repo and not the Debian / Ubuntu repo.
  2. Keep Compose as a standalone binary and use v2

Personally, I'd be in favor of following approach 1 and using the official Docker repos, like we're already recommending for CentOS / Fedora. This would ease the setup for users, because they can just install everything in one single command, but also introduces a dependence on Docker. Switching from Compose standalone to the Compose plugin however would require to change all occurrences of docker-compose to docker compose. To not go beyond the scope of this PR and risk redundant work, I therefore opted for approach 2 (for now). If e.g. @bjoernricks is also for approach 1, I'm happy to adjust this PR.

References

Checklist

n-thumann commented 1 year ago

Will be shortly superseded by another PR.