greenbone / gvm-tools

Remote control your Greenbone Community Edition or Greenbone Enterprise Appliance
https://greenbone.github.io/gvm-tools/
GNU General Public License v3.0
162 stars 89 forks source link

Main #1097

Closed martinboller closed 2 months ago

martinboller commented 4 months ago

What

Additional and changed scripts for maintaining Greenbone and automating the creation of credentials, schedules, alerts, targets, tasks, tags and filters.

Why

To automate the creation of a completely configured Greenbone Scanner

References

Original gvm-tools scripts.

github-actions[bot] commented 4 months ago

Conventional Commits Report

:cry: No conventional commits found.

:point_right: Learn more about the conventional commits usage at Greenbone.

y0urself commented 4 months ago

@martinboller I would really love to merge this - is there any chance, that you fix up the stuff?

martinboller commented 4 months ago

Will these changes satisfy requirements or am I missing something (or everything)

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 130 lines in your changes are missing coverage. Please review.

Project coverage is 47.81%. Comparing base (fdb6dec) to head (5968d5c). Report is 21 commits behind head on main.

Files Patch % Lines
scripts/stop-scans-from-csv.py 0.00% 66 Missing :warning:
scripts/start-scans-from-csv.py 0.00% 64 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1097 +/- ## ========================================== - Coverage 53.55% 47.81% -5.74% ========================================== Files 15 17 +2 Lines 1083 1213 +130 ========================================== Hits 580 580 - Misses 503 633 +130 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

y0urself commented 3 months ago

Will these changes satisfy requirements or am I missing something (or everything)

No actually my suggestions were just examples, e.g. the Copyright header should have been updated in every file ... Also running black and ruff in every file has not been done ...

y0urself commented 2 months ago

merged through #1112