greenbone / openvas-scanner

This repository contains the scanner component for Greenbone Community Edition.
https://greenbone.github.io/docs/
GNU General Public License v2.0
3.37k stars 621 forks source link

Cannot use space in username #159

Closed TheGroundZero closed 6 years ago

TheGroundZero commented 6 years ago

Expected behavior

Successfully create a new credential with a space in the username.

Current behavior

(Status code: 400) Operation 'Create Credential' failed Given login was invalid

Steps to reproduce

  1. Create a new credential
  2. Enter username with a space in it
  3. Try to save credential

GVM versions

gsa: (gsad --version)
7.0.3

gvm: (gvmd --version)
/

openvas-scanner: (openvassd --version)
5.1.3

gvm-libs:

openvas-smb:

Environment

Operating system:
Greenbone Security Manager Community Edition

Installation method / source: (packages, source installation)
ISO from site

Logfiles

jjnicola commented 6 years ago

Hello @TheGroundZero, spaces in credential in username are currently not allowed. Therefore, this is not a bug, but the message shown could be improved. I suggest you to open a new issue in the right project greenbone/gvm if you have still any concern. Regards, Juan

Closing here since is not a proper openvas-scanner issue.

TheGroundZero commented 6 years ago

While definitely not recommended, it is possible to create accounts with spaces in the username (e.g. on Windows systems).

The current configuration of the scanner as such prevents a user from testing systems where a username contains a space (and it is not possible to create a seperate account for testing).

If not a bug, I would request you consider this to be at least a Feature Request.

cfi-gb commented 6 years ago

As a side-note the scanner is not responsible for this task. It could still worth to create a new issue at https://github.com/greenbone/gvm/issues to make the error message at least include the info that an unsupported char is used.