search

greenbone / ospd

OSPd is a framework for vulnerability scanners which share the same communication protocol: OSP (Open Scanner Protocol)
GNU Affero General Public License v3.0
30 stars 36 forks source link

[20.8.1] tests are installed #330

Closed tuxmaster5000 closed 4 years ago

tuxmaster5000 commented 4 years ago

After call setup.py install, the following files will installed: /usr/lib/python3.6/site-packages/tests/command/init.py /usr/lib/python3.6/site-packages/tests/command/pycache/init.cpython-36.opt-1.pyc /usr/lib/python3.6/site-packages/tests/command/pycache/init.cpython-36.pyc /usr/lib/python3.6/site-packages/tests/command/pycache/test_command.cpython-36.opt-1.pyc /usr/lib/python3.6/site-packages/tests/command/pycache/test_command.cpython-36.pyc /usr/lib/python3.6/site-packages/tests/command/pycache/test_commands.cpython-36.opt-1.pyc /usr/lib/python3.6/site-packages/tests/command/pycache/test_commands.cpython-36.pyc /usr/lib/python3.6/site-packages/tests/command/pycache/test_registry.cpython-36.opt-1.pyc /usr/lib/python3.6/site-packages/tests/command/pycache/test_registry.cpython-36.pyc /usr/lib/python3.6/site-packages/tests/command/test_command.py /usr/lib/python3.6/site-packages/tests/command/test_commands.py /usr/lib/python3.6/site-packages/tests/command/test_registry.py

I think, the test files should not be installed on the target.

bjoernricks commented 4 years ago

Already fixed in master with #317. Will come with next release. Just as a side note, we don't use setup.py to build the distributables. We are using poetry build which doesn't include the test directory.