greenbone / pg-gvm

Greenbone Library for helper functions in PostgreSQL
GNU General Public License v3.0
7 stars 15 forks source link

CMAKE_INSTALL_DEV_PREFIX ? #40

Open Virsacer opened 2 years ago

Virsacer commented 2 years ago

Hi, the build script outputs the value of CMAKE_INSTALL_PREFIX as "install prefix" but then actually uses CMAKE_INSTALL_DEV_PREFIX instead...

bjoernricks commented 2 years ago

It should use the DEV_PREFIX only if it is set https://github.com/greenbone/pg-gvm/blob/main/CMakeLists.txt#L183

Virsacer commented 2 years ago

Then https://github.com/greenbone/pg-gvm/blob/main/CMakeLists.txt#L40 should use the same variable.

bjoernricks commented 2 years ago

Sorry I don't get that. CMAKE_INSTALL_DEV_PREFIX should only be used by developers during development. It is of no interest for users of a released version.

Virsacer commented 2 years ago

When only CMAKE_INSTALL_PREFIX is set or only CMAKE_INSTALL_DEV_PREFIX is set or they are set to different values the output contains something like this:

install prefix: /A
...
copying files to /B

Just saying: These should be consistent.