Location.url() returns js.Object instead of String

[easel]

I got some UBE's attempting to use Location.url(). Apparently the return result is an object, not a string.

[mysticfall]

Could you give me a reference about the suggested change?

The documentation specifies the return type of the mentioned method to be of string type, and I just did a quick test myself but was unable to reproduce the problem.

• https://docs.angularjs.org/api/ng/service/$location

Please let me know if I am missing something here. And sorry for the late response again!

[easel]

Here's the issue:

https://github.com/angular/angular.js/blob/v1.4.x/src/ng/location.js#L392

When you call .url("someNewThing") it modifies the url and then returns this, which isn't a string. The "getter" does return a string. Perhaps the better ascription would be String | Location?

[mysticfall]

Thanks for the confirmation. And I agree that the suggested change would make it even clearer. Could you modify the PR using the union type?

[easel]

Yeah will do.

[easel]

Ok I think this is actually a better solution. I've split the two methods by making "url" non-optional. So far, it seems to work as expected =p

[mysticfall]

Oh, thanks! It's way better, indeed :) By the way, isn't there a typo that the url parameter missing type definition?

[easel]

Yeah good catch, I guess I forgot to push the branch after fixing that. Should be good to go now.

[mysticfall]

Merged now. Thanks for the contribution!

[easel]

Thanks for the merge!